https://bugzilla.redhat.com/show_bug.cgi?id=1671571 Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dridi.boukelmoune@xxxxxxxxx --- Comment #1 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- I can't sponsor you, but I will do the formal review once you have a sponsor. And as per bug 1266594 I would like to co-maintain this package since I'm currently using my own build of the package and have a vetted interest here. Before the formal review, I have a few nits after a quick read of the spec: For the summary, please stick to "Command-line MPRIS-compatible Media Player Controller" instead of mentioning services like spotify or software like VLC that aren't fit for inclusion in Fedora. You shouldn't need to "Requires: glib", I didn't for my local build. For the Source URL, please use upstream's official release archive instead of deriving one from the github API: https://github.com/acrisci/playerctl/releases/download/v2.0.1/playerctl-2.0.1.tar.xz They also provide a SHA-256 checksum that you should use before you upload the archive to the look-aside cache. The license should be LGPLv3+ because upstream clearly uses "or (at your option) any later version" in its source files. I didn't check whether other licenses apply. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
