https://bugzilla.redhat.com/show_bug.cgi?id=1669793 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hiwkby@xxxxxxxxx --- Comment #2 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hello, this is an unofficial review. Please read it for your reference. Summary ======= 1. rpmbuild error 2. rpmlint result 3. License 4. Others Details ======= 1. rpmbuild error ----------------- The 'sphinx-build' command, which is provided by python2-sphinx, is required in "make -O -C docs html". sphinx-build-3 should be used in this case. 2. rpmlint on the binary rpm ----------------------------- rpmlint on the binary rpm package in my environment(fc29) reports errors and warnings. * spelling-error warnings are not problems. * wrong-script-interpreter errors can be problems when users manually install them. Here is the guideline. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines * hidden-file-or-dir warning should be fixed if the hidden file is no use for users. * no-manual-page-for-binary should be fixed. Here is the guideline. You might know that help2man is a useful tool. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages :: python3-vpoller.noarch: W: spelling-error Summary(en_US) vSphere -> v Sphere, sphere python3-vpoller.noarch: W: spelling-error %description -l en_US vSphere -> v Sphere, sphere python3-vpoller.noarch: E: wrong-script-interpreter /usr/share/doc/python3-vpoller/contrib/zabbix/externalscripts/cvpoller-zabbix /usr/bin/env bash python3-vpoller.noarch: E: wrong-script-interpreter /usr/share/doc/python3-vpoller/contrib/zabbix/externalscripts/vpoller-zabbix /usr/bin/env bash python3-vpoller.noarch: E: wrong-script-interpreter /usr/share/doc/python3-vpoller/extra/misc-tools/bootstrap-vpoller.sh /usr/bin/env sh python3-vpoller.noarch: E: wrong-script-interpreter /usr/share/doc/python3-vpoller/extra/misc-tools/request-simulator.sh /usr/bin/env bash python3-vpoller.noarch: E: wrong-script-interpreter /usr/share/doc/python3-vpoller/extra/zabbix/externalscripts/cvpoller-zabbix /usr/bin/env sh python3-vpoller.noarch: E: wrong-script-interpreter /usr/share/doc/python3-vpoller/extra/zabbix/externalscripts/cvpoller-zabbix-vm-disk-get /usr/bin/env sh python3-vpoller.noarch: E: wrong-script-interpreter /usr/share/doc/python3-vpoller/extra/zabbix/externalscripts/vpoller-zabbix /usr/bin/env sh python3-vpoller.noarch: E: wrong-script-interpreter /usr/share/doc/python3-vpoller/extra/zabbix/vsphere-import/zabbix-vsphere-import /usr/bin/env python python3-vpoller.noarch: W: hidden-file-or-dir /usr/share/doc/python3-vpoller/html/.buildinfo python3-vpoller.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-vpoller/html/objects.inv python3-vpoller.noarch: W: file-not-utf8 /usr/share/doc/python3-vpoller/html/objects.inv python3-vpoller.noarch: W: no-manual-page-for-binary vpoller-client python3-vpoller.noarch: W: no-manual-page-for-binary vpoller-proxy python3-vpoller.noarch: W: no-manual-page-for-binary vpoller-worker 1 packages and 0 specfiles checked; 8 errors, 8 warnings. 3. License ----------- py-vpoller is licensed under the BSD License, but are files in contrib dir and extra also licensed under the BSD License? If not clear, it is always preferred to ask upstream. See the following guideline. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_clarification 4. Others --------- Fedora guideline recommends putting "python_enable_dependency_generator" just before the main package’s %description declaration. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies You can use the %{py_dist_name} macro that simply transforms any standardized name to the canonical format. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_requires_and_buildrequires_with_standardized_names For example:: > BuildRequires: python%{python3_pkgversion}-docopt > BuildRequires: python%{python3_pkgversion}-zmq > BuildRequires: python%{python3_pkgversion}-vconnector > BuildRequires: python%{python3_pkgversion}-pyvmomi > BuildRequires: python%{python3_pkgversion}-sphinx could be:: > BuildRequires: %{py3_dist docopt zmq vconnector pyvmomi sphinx} Thanks in advance, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
