https://bugzilla.redhat.com/show_bug.cgi?id=1671273 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mhroncok@xxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- https://github.com/corydolphin/%{srcname}/archive/%{version}.tar.gz#/%{srcname}-%{version}.tar.gz github knows this: https://github.com/corydolphin/%{srcname}/archive/%{version}/%{srcname}-%{version}.tar.gz you could also use: %{url}/archive/%{version}/%{srcname}-%{version}.tar.gz -------- Requires: %{py3_dist flask six} There are automatic requires, drop this. If you target anything but rawhide, enable this manually via %{?python_enable_dependency_generator}. ------- Package uses setuptools. BuildRequire python3-setuptools explicitly. ------- Use the python_provide macro as mentioned in the Python packaging guidelines ------- I've never seen {%py3_build} only %{py3_build} or %py3_build - is this some style of yours? It evals to: {\ CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" LDFLAGS="${LDFLAGS:-${RPM_LD_FLAGS}}"\ /usr/bin/python3 setup.py build --executable="/usr/bin/python3 -s" sleep 1 } So the commands are grouped via {}. I don't think this was intentional. The same for %py3_install. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
