https://bugzilla.redhat.com/show_bug.cgi?id=1670656 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@xxxxxxxxxxxx --- Comment #1 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- Just some preliminary comments. Spec URL shouild point at the raw file. Summary don't need to duplicate the package name. Source0 should be a full URL. https://github.com/grafana/grafana/archive/v%{version}/%{name}-%{version}.tar.gz # Fedora/FSH and config patch Typo s/FSH/FHS/ also elsewhere in the spec. %defattr(-,root,root,-) Not needed, this is the default. %post could probably use some systemd macros to be made simpler. https://fedoraproject.org/wiki/Packaging:Scriptlets#Scriptlets Generally speaking, %post and %posttrans looks quite complicated and doing too much. Maybe that could be made simpler ? Some config files are no marked %config(noreplace). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
