https://bugzilla.redhat.com/show_bug.cgi?id=1659286 --- Comment #12 from Alfredo Moralejo <amoralej@xxxxxxxxxx> --- Some comments: - Directories /usr/lib/python3.7/site-packages/openshift are orphaned. Lines %{python2_sitelib}/%{library}/* and %{python3_sitelib}/%{library}/* should be %{python2_sitelib}/%{library} and %{python3_sitelib}/%{library} (without "/*") so that the directory itself is included in the package. Could this be fixed?, fedora-review is complaining about it. Also some other comments (not blocking approval): - It'd be great to run unit tests in %check. What deps are missing to be able to run them?, it'd be nice to fix it as follow up. - About requirements.txt and adding deps to setup.py, they could be totally removed and rely on rpm requires for dependencies management. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
