https://bugzilla.redhat.com/show_bug.cgi?id=1667661 --- Comment #3 from Patrik Kopkan <pkopkan@xxxxxxxxxx> --- REVIEW: Done Must Items: - Package is named according Package Naming Guidelines - The spec file name matches the base package - The package meets Packaging guidelines - License of package is approved in fedora - %files section contains license - Spec file is written in American English - Spec file is legible - sha256sum is same for sources from github: dab3e426715373fd76cd08bb1abe64b550f5aa494cf1e32384f26fd60961eb67 from srpm: dab3e426715373fd76cd08bb1abe64b550f5aa494cf1e32384f26fd60961eb67 - Package builds properly https://koji.fedoraproject.org/koji/taskinfo?taskID=32228374 - Package doesn't bundle system libraries - Package owns all directories that it creates - Package does not own files or directories owned by other packages. - No duplications in %file section. - Permissions are set properly - Package includes %doc, it doesn't affect runtime - Package does not containg any libtool archives - All filenames in package are valid UTF-8 - Package does not rely on deprecated dependencies Not aplicable must items: - The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden - If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch - have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. - Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. -If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. - Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). - Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation Should items: - package builds in mock rpmlint output: python-astunparse.src: W: spelling-error Summary(en_US) unparser -> sparser, parser python-astunparse.src: W: spelling-error %description -l en_US unparse -> parse python3-astunparse.noarch: W: spelling-error Summary(en_US) unparser -> sparser, parser python3-astunparse.noarch: W: spelling-error %description -l en_US unparse -> parse This is not problem because unparse is an IT term: https://en.wiktionary.org/wiki/unparse -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
