https://bugzilla.redhat.com/show_bug.cgi?id=1481630 --- Comment #89 from Sergio Monteiro Basto <sergio@xxxxxxxxxx> --- (In reply to Hans de Goede from comment #88) > Hi, > > Thank you for your work on maintaining the vbox guest-additions package in > Fedora. > > (In reply to Sergio Monteiro Basto from comment #86) > > BTW please review > > > https://src.fedoraproject.org/rpms/virtualbox-guest-additions/blob/master/f/ > > 010-linux-4.16-mount-fixes.patch > > This one is not necessary and can be dropped. > > > https://src.fedoraproject.org/rpms/virtualbox-guest-additions/blob/master/f/ > > 0001-VBoxServiceAutoMount-Change-Linux-mount-code-to-use-.patch > > This patch looks good, thank you for rebasing it. > > Regards, > > Hans Hi , thanks for the reply , another question, can we use new vboxsf source [1] in el7 ? i.e. instead use new vboxsf source [1] code only in F28+ [2], can I use it for all cases (el7 and old F27 for example ) ? BTW in vboxsf-master/super.c line 153 if (flags & MS_REMOUNT) FTBFS with kernel 5.0.0-rc3 , I'm testing add this [3] to source code , based on [4] Thanks. [1] https://github.com/jwrdegoede/vboxsf [2] %if 0%{?fedora} > 27 %bcond_without newvboxsf %else %bcond_with newvboxsf %endif [3] #if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 0, 0) # include <uapi/linux/mount.h> #endif [4] https://github.com/torvalds/linux/commits/master/security/tomoyo/mount.c https://github.com/torvalds/linux/commit/e262e32d6bde0f77fb0c95d977482fc872c51996#diff-445cd3f3706b497a6e327c47d03ee661 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
