https://bugzilla.redhat.com/show_bug.cgi?id=1662572 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hiwkby@xxxxxxxxx --- Comment #5 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hello, this is an unofficial and an additional review to #3. Summary ======== 1. Koji scratch build succeeded 2. Package Naming 3. Package Dependencies 4. Provides 5. Source Appendix 1: "diff" with my locally edited spec file Details ======== 1. Koji scratch build succeeded --------------------------------- https://koji.fedoraproject.org/koji/taskinfo?taskID=32254139 Here is the reference to run a koji scratch build. https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds 2. Package Naming ------------------ The current binary rpm name, python-aiohttp-socks, must be python3-aiohttp-socks. I think "%files" in python-aiohttp-socks.spec should be "%files -n python3-%{pypi_name}". See the "diff" with locally edited spec file of mine for details. The following guideline will help you. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming 3. Package Dependencies ------------------------ This package requires python3-aiohttp package. I think you should add "%{?python_enable_dependency_generator}" to you spec file. See the "diff" with locally edited spec file of mine for details. "Automatically generated dependencies" in Python guideline will help you. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies "All package dependencies (build-time or runtime, regular, weak or otherwise) MUST ALWAYS be satisfiable within the official Fedora repositories." See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies 4. Provides ------------ "Provides: python3-aiohttp-socks" is needed because this package will be pulled in as build dependencies using the package name. "%python_provide" macro will help you. See the following guideline. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides 5. Source Reference -------------------- SourceX is usually used because source files can be multiple. I think Source0 is better in this case. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Appendix 1: "diff" with my locally edited spec file ---------------------------------------------------- Here is the diff between the original spec file in #2 and my locally edited spec file for your reference.:: $ diff -c python-aiohttp-socks.spec.orig python-aiohttp-socks.spec *** python-aiohttp-socks.spec.orig 2019-01-26 06:51:27.077180489 +0000 --- python-aiohttp-socks.spec 2019-01-26 06:53:21.317238974 +0000 *************** *** 10,25 **** License: ASL 2.0 URL: https://pypi.org/project/aiohttp-socks/ ! Source: %{pypi_source} BuildArch: noarch %description %{_description} %package -n python3-%{pypi_name} Summary: %{summary} BuildRequires: python3-devel BuildRequires: python3-setuptools %description -n python3-%{pypi_name} %{_description} --- 10,27 ---- License: ASL 2.0 URL: https://pypi.org/project/aiohttp-socks/ ! Source0: %{pypi_source} BuildArch: noarch + %{?python_enable_dependency_generator} %description %{_description} %package -n python3-%{pypi_name} Summary: %{summary} BuildRequires: python3-devel BuildRequires: python3-setuptools + %{?python_provide:%python_provide python3-%{srcname}} %description -n python3-%{pypi_name} %{_description} *************** *** 35,41 **** %install %py3_install ! %files %license LICENSE.txt %doc README.md %{python3_sitelib}/%{srcname}/ --- 37,43 ---- %install %py3_install ! %files -n python3-%{pypi_name} %license LICENSE.txt %doc README.md %{python3_sitelib}/%{srcname}/ Thanks in advance. Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
