https://bugzilla.redhat.com/show_bug.cgi?id=1667725 Jonathan Wakely <jwakely@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #11 from Jonathan Wakely <jwakely@xxxxxxxxxx> --- The spec file looks good. It could be improved by adding some missing Requires: but those are also (currently) missing from the Boost package in Fedora. That could be done later, so I'll approve this anyway. Here's what I did for the boost-1.66.0-6.el8 package: @@ -183,6 +183,10 @@ provides a sort of cooperative multitasking on a single thread. %package coroutine Summary: Run-time component of boost coroutine library +Requires: boost-chrono%{?_isa} = %{version}-%{release} +Requires: boost-context%{?_isa} = %{version}-%{release} +Requires: boost-system%{?_isa} = %{version}-%{release} +Requires: boost-thread%{?_isa} = %{version}-%{release} %description coroutine Run-time support for Boost.Coroutine, a library that provides @@ -202,6 +206,9 @@ on generic programming concepts. %if %{with context} %package fiber Summary: Run-time component of boost fiber library +Requires: boost-context%{?_isa} = %{version}-%{release} +Requires: boost-filesystem%{?_isa} = %{version}-%{release} +Requires: boost-system%{?_isa} = %{version}-%{release} %description fiber @@ -250,6 +257,13 @@ handling tools. %package log Summary: Run-time component of boost logging library +Requires: boost-atomic%{?_isa} = %{version}-%{release} +Requires: boost-chrono%{?_isa} = %{version}-%{release} +Requires: boost-date-time%{?_isa} = %{version}-%{release} +Requires: boost-filesystem%{?_isa} = %{version}-%{release} +Requires: boost-regex%{?_isa} = %{version}-%{release} +Requires: boost-system%{?_isa} = %{version}-%{release} +Requires: boost-thread%{?_isa} = %{version}-%{release} %description log @@ -310,6 +324,7 @@ Shared object symbolic links for Python 3 variant of Boost.Python. %package random Summary: Run-time component of boost random library +Requires: boost-system%{?_isa} = %{version}-%{release} %description random @@ -353,6 +368,8 @@ the diagnostics support that is part of the C++11 standard library. %package test Summary: Run-time component of boost test library +Requires: boost-system%{?_isa} = %{version}-%{release} +Requires: boost-timer%{?_isa} = %{version}-%{release} %description test @@ -385,6 +402,7 @@ with as little as one #include and one additional line of code. Summary: Run-time component of boost type erasure library Requires: boost-chrono%{?_isa} = %{version}-%{release} Requires: boost-system%{?_isa} = %{version}-%{release} +Requires: boost-thread%{?_isa} = %{version}-%{release} %description type_erasure @@ -1275,6 +1293,9 @@ fi %{_mandir}/man1/bjam.1* %changelog +* Tue Oct 09 2018 Jonathan Wakely <jwakely@xxxxxxxxxx> - 1.66.0-6 +- Add explicit Requires to subpackages that depend on other parts of boost + -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
