Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qfits - A stand-alone general purpose FITS library https://bugzilla.redhat.com/show_bug.cgi?id=244031 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-09-21 12:59 EST ------- For 6.2.0-1: ! Naming suggestion - Well, IMO it is better that * qfits should be renamed to qfits-libs * qfits-libs should be renamed to qfits * Requires for /sbin/ldconfig - "Requires(post,postun): /sbin/ldconfig" is not needed. (Still %post, %postun themselves are needed) * defattr - We now recommend %defattr(-,root,root,-) * Timestamps - For keeping timestamps, I recommend ----------------------------------------------------- %{__make} DESTDIR=%{buildroot} INSTALL="%{__install} -p" install ------------------------------------------------------ This will keep timestamps on installed header files and man files ! Note: The method above usually works on recent Makefile. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review