https://bugzilla.redhat.com/show_bug.cgi?id=1662526 --- Comment #5 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Hi, Ankur. The new version looks better. 1. I read your comment at the top of the spec: > # This is a serial build of NEURON without Python or other bindings. > # Both the MPI builds and Python bindings require NEURON to be already > # installed in the system---they are build as post-installation hooks. So, we > # first package a serial version of NEURON and then package those separately > # after using this package as a BR Are you sure this is really the case? Looking at src/nrnmpi/Makefile.am, it seems that specifying the path to the just-built libraries should suffice to build it after the serial version is built. 2. I noticed that many source files under src/ have executable permission bits. I'd suggest something like this in %prep: find src -type f -executable ! -name "*.sh" | xargs chmod -x 3. The header file in -devel subpackage: # should this be here?! %{_libdir}/nrnconf.h It shouldn't. Please put it in %{_includedir} . 4. It looks like there's more bundled code: src/gnu - libstdc++-devel (?) src/readline - readline-devel 5. You might want to change the License: tag to GPLv3, because two files are GPLv3: ./src/ivoc/nrngsl_hc_radix2.c: GPL (v3 or later) ./src/ivoc/nrngsl_real_radix2.c: GPL (v3 or later) Do check if they're compiled and included in the binaries. 6. README.md isn't very useful for the installed package as it talks only about installing from source. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
