Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: generic-logos - Icons and pictures https://bugzilla.redhat.com/show_bug.cgi?id=290041 ------- Additional Comments From notting@xxxxxxxxxx 2007-09-21 12:36 EST ------- (In reply to comment #2) > Issues: > > 1. Should the > # should be ifarch i386 > bits really be %ifarch? why aren't they now... It's a noarch package, and making it per-arch probably isn't worth it. > 2. I assume cvs is the Source for this package? > Perhaps it would be worth making a hosted project in case people want to > work on/contribute to this package? At the moment, it's CVS on my laptop. Will move to somewhere @ fp.o once it's approved. > 3. rpmlint says: > > generic-logos.noarch: W: no-url-tag > generic-logos.src: W: no-url-tag > > A hosted (or other upstream) would fix this. > > generic-logos.noarch: E: only-non-binary-in-usr-lib > > Ignore since it has to put anaconda-runtime has to be there. > > generic-logos.src:10: W: unversioned-explicit-obsoletes redhat-logos > > Can you specifiy a version on that Obsoletes? Not sure what the last version is. The idea is to obsolete any redhat-logos from earlier RHL or RHEL releases. > generic-logos.src:70: E: hardcoded-library-path in /usr/lib/anaconda-runtime/*.jpg > > No way to avoid that I see off hand. Do you? That's where anaconda is looking for it. > generic-logos.src: W: strange-permission generic-logos.spec 0600 > > Spec should be 644. AFAICT, this is a RPM bug. It's 0644 in the tarball, and the source RPM is built with -ts. > 4. Should this package Require the anaconda, grub, and other packages > where it places images in dirs they own? Or should this be an exception > to that rule? Hm. fedora-logos very specifically doesn't do this, because you don't want the grub splash pulling in anaconda, for example. This would fall in the same category. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review