[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1545479



--- Comment #7 from Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> ---
I rebuilt your updated hcc package on Fedora 29 which worked fine. The
resulting "hcc" binary seems to work. I was able to run "saxpy" and several
example programs from
https://github.com/ROCm-Developer-Tools/HCC-Example-Application .

Just for reference: I'm able to run the "saxpy" example from
https://github.com/RadeonOpenCompute/hcc/wiki#how-to-use-hcc when invoking hcc
like this: hcc `hcc-config --cxxflags --ldflags` -I/usr/include/hcc saxpy.cpp
-o saxpy

I noticed some things:
The hcc package contains multiple copies of the same header file, e.g.
kalmar_aligned_alloc.h is available via /usr/include/ and /usr/include/hcc/. I
saw a patch in the SRPM which tried to move everything to the "hcc"
subdirectory but I guess you missed at least on spot.

Also there are some rpmlint errors (which I guess you are aware of already),
e.g. that "hcc" requires "hcc-runtime-devel". As hcc is a compiler I think that
is basically ok (compiler requires header files for its "standard library") but
maybe these files are just part of the "hcc-runtime"?
rpmlint also complained about some rpaths in binaries like hcc and libraries
like "LLVMPromotePointerKernArgsToGlobal.so".

"hcc-config --cxxflags" still returns "-I/opt/rocm/include" but lacks
"-I/usr/include/hcc/". Same applies to "clamp-config" (and I was wondering why
"clamp-config" was available at all as I read that ROCm 2.0 drop C++ AMP
support - but that is likely due to my limited understanding/an upstream
issue).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux