https://bugzilla.redhat.com/show_bug.cgi?id=1666545 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hiwkby@xxxxxxxxx --- Comment #2 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> --- Hello, this is an unofficial review. Please read it for your reference. Summary: 1. Rpmlint 4 errors, 3 warnings. 2. No files under the CC-BY License are included. 3. No Test suites exist. 4. No python3-setuptools in BuildRequires. Details: 1. Rpmlint '/usr/bin/env python' MUST NOT be used in shebang lines. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes python3-qdarkstyle SHOULD contain the manpage of /usr/bin/qdarkstyle. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages Here is the output of rpmlint on the binary rpm package in my fedora29 environment: ``` python3-qdarkstyle.noarch: W: spelling-error Summary(en_US) stylesheet -> style sheet, style-sheet, stylishness The value of this tag appears to be misspelled. Please double-check. python3-qdarkstyle.noarch: W: spelling-error %description -l en_US stylesheet -> style sheet, style-sheet, stylishness The value of this tag appears to be misspelled. Please double-check. python3-qdarkstyle.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/qdarkstyle/__init__.py /usr/bin/env python This script uses an interpreter which is either an inappropriate one or located in an inappropriate directory for packaged system software. python3-qdarkstyle.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/qdarkstyle/__init__.py 644 /usr/bin/env python This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. python3-qdarkstyle.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/qdarkstyle/__main__.py /usr/bin/env python This script uses an interpreter which is either an inappropriate one or located in an inappropriate directory for packaged system software. python3-qdarkstyle.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/qdarkstyle/__main__.py 644 /usr/bin/env python This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. python3-qdarkstyle.noarch: W: no-manual-page-for-binary qdarkstyle Each executable in standard binary directories should have a man page. 1 packages and 0 specfiles checked; 4 errors, 3 warnings. ``` 2. No file under the CC-BY License. I think images are distributed under the CC-BY license, but no images are included. Does this package need to include them? If not, License: field value should be 'MIT' only because The License: field refers to the licenses of the contents of the binary rpm. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_field 3. No Test suites. If upstream provides a test suite and it is practical, you should add it to the %check section. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites 4. No python3-setuptools in BuildRequires. upstream uses setuptools to build this package. setuptools is a very common package, but it is important that your package list all necessary build dependencies using the BuildRequires: tag. https://docs.fedoraproject.org/en-US/packaging-guidelines/#buildrequires Thanks in advance, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
