https://bugzilla.redhat.com/show_bug.cgi?id=1667174 --- Comment #2 from Robert Fairley <rfairley@xxxxxxxxxx> --- Thank you Dennis for reviewing. I made some changes: - Added the missing systemd-udev Requires - Added a Requires for fedora-release - Added conditionals for the selinux-policy version (before the version given in the Requires was only built for Rawhide). - Added a condition for pam to only be a requirement if openssh is installed For the fedora-release Requires, I will need to add a (fedora-release >= *version*) once a patch to fedora-release that includes `/etc/issue.d` is made. Will be opening a PR shortly for that, will post the link here. For the selinux-policy Requires, these version numbers will need to be updated once a fix is made to the policy (https://github.com/fedora-selinux/selinux-policy/issues/242). Some functionality will still work without the selinux-policy patches though; so I don't think the patches need to be a hard Requires. Since the selinux-policy versions apply only when using sshd, I made those Requires apply only where openssh is installed. The updated specfile is here: https://copr-be.cloud.fedoraproject.org/results/rfairley/console-login-helper-messages/fedora-rawhide-x86_64/00848024-console-login-helper-messages/console-login-helper-messages.spec (also the diff here with the changes): https://github.com/rfairley/console-login-helper-messages/commit/850e3c2b5c6c2bb11148af21215b242b780caf77 The updated SRPM is here: https://copr-be.cloud.fedoraproject.org/results/rfairley/console-login-helper-messages/fedora-rawhide-x86_64/00848024-console-login-helper-messages/console-login-helper-messages-0.12-2.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
