https://bugzilla.redhat.com/show_bug.cgi?id=1665563 --- Comment #5 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Almost there: - please re-generate the spec with the git source. review-helper complains of an md5check error: https://github.com/danvk/RangeHTTPServer/archive/1.2.0/rangehttpserver-1.2.0.tar.gz : CHECKSUM(SHA256) this package : ce47a420d04c8161d28f35538b3d2fc77cea5c54968c3e3e6a508d64e04ea7a2 CHECKSUM(SHA256) upstream package : 17aad58bec8ccd95f9d5bc9cff2bf3597d002eff08e1ced558c8756b61467a94 diff -r also reports differences - the source tar does include a LICENSE file. Please include it. - the tests are commented out: do they not run? - please correct rpmlint errors: python3-rangehttpserver.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/RangeHTTPServer/__init__.py 644 /usr/bin/python python3-rangehttpserver.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/RangeHTTPServer/__main__.py 644 /usr/bin/python - Please include python3-setuptools in BR explicitly - Package appears to require nose for tests: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
