https://bugzilla.redhat.com/show_bug.cgi?id=1658153 --- Comment #16 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> --- > What can be improvided ? 1. Name the spec file correctly, wdune-0.99.spec isn't acceptable. It should be wdune.spec 2. Use the file macros, you have already been asked to do so https://bugzilla.redhat.com/show_bug.cgi?id=1658153#c11 you missed /%{_datadir}/man/man1/dune.1* /%{_datadir}/man/man1/dune4kids.1* /%{_datadir}/man/man1/illegal2vrml.1* also why the / on everything in files? 3. remove %defattr(-,root,root) from files 4. Spec file readability is poor, long lines aren't easy to read even on my hidpi monitor so shorten them to %configure \ --with-optimization \ --without-devil \ --with-vrmlbrowser=firefox \ --with-helpurl="/usr/share/doc/wdune/docs/" \ --with-protobaseurl="/usr/share/doc/wdune/docs" \ --with-checkincommand="ci" \ --with-imageeditor="kolourpaint" \ --with-imageeditor4kids="kolourpaint" \ --with-soundeditor=audacity %make_build desktop-file-install \ --add-category="Graphics" \ --delete-original \ --dir=$RPM_BUILD_ROOT/%{_datadir}/applications \ $RPM_BUILD_ROOT//%{_datadir}/applications/dune.desktop 5. Changelog version doesn't match the package version change this * Wed Sep 20 2017 J. Scheurich <mufti11@xxxxxx> 0.99pl765 to * Wed Sep 20 2017 J. Scheurich <mufti11@xxxxxx> - 0.99-1.pl1276 and remove the extra release tag from it -- Initial packaging Release: 2%{?dist} 6. Why doesn't the source match the url?, have you added spyware or done something to it? ;-) $ rpmlint '/home/leigh/Downloads/wdune-0.99-1.pl1276.fc29.src.rpm' wdune.src: W: spelling-error %description -l en_US webgl -> webbing wdune.src: W: spelling-error %description -l en_US maya -> Maya, may, mayo wdune.src: W: spelling-error %description -l en_US catia -> cation wdune.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml wdune.src: W: spelling-error %description -l en_US localisation -> localization, allocations, vocalization wdune.src: W: file-size-mismatch wdune-0.99.tar.bz2 = 25092682, ftp://ftp.ourproject.org/pub/wdune/wdune-0.99.tar.bz2 = 24391645 1 packages and 0 specfiles checked; 0 errors, 6 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
