https://bugzilla.redhat.com/show_bug.cgi?id=1664384 --- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Several style issues: 1. While technically tabs are fine, I think (especially in Pythonh spec files), you should stick to spaces. Also, there is some trailing whitespace. 2. "PyPi library" isn't quite right. (It is spell PyPI and I'd prefer "Python library"). 3. You can use %{summary} for the contents of the second summary to DRY. 4. Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. (Use the rpmlint tool on the source rpm or the built rpm to get this info.) 5. The "many tests are skipped" doesn't sound very useful, but that's not a strong opinion. Technical issue: 1. The package uses setuptools at build. Better BuildRequire python3-setuptools explicitly. Everything else looks quite good, will do some more testing and checks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
