https://bugzilla.redhat.com/show_bug.cgi?id=1662974 --- Comment #4 from Petra Alice Mikova <pmikova@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Packages have proper BuildRequires/Requires on jpackage-utils - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Package uses hardened build flags if required to. Note: suid files: fernflower and not %global _hardened_build See: http://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags - Package has no changelog. - there are typos and errors in the comments: this source is 280MB big, so only decompiler is repacked via create-sources.sh and have 350kB => this source is 280MB big, so only the decompiler is repacked via create-sources.sh and has 350kB tests are nto run in rpm build anyway => tests are not run in rpm build anyway - there are more in rpmlint check ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License (v2.0)", "Unknown or generated". 177 files have unknown license. Detailed output of licensecheck in /home/pmikova/fedora_repos/fedora- reviews/1662974-fernflower/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package is not known to require an ExcludeArch tag. [!]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build Maven: [-]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil} [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fernflower-183.5153.8-1.fc29.noarch.rpm fernflower-183.5153.8-1.fc29.src.rpm fernflower.noarch: W: spelling-error Summary(en_US) decompiler -> recompiled, compiler, recompile fernflower.noarch: W: summary-not-capitalized C fernflower java decompiler fernflower.noarch: W: name-repeated-in-summary C fernflower fernflower.noarch: W: spelling-error %description -l en_US analytical -> analytically, analytic, catalytic fernflower.noarch: W: spelling-error %description -l en_US decompiler -> recompiled, compiler, recompile fernflower.noarch: E: description-line-too-long C Fernflower is the first actually working analytical decompiler for Java and probably fernflower.noarch: E: description-line-too-long C for a high-level programming language in general. Naturally it is still under development, fernflower.noarch: E: no-changelogname-tag fernflower.noarch: E: setuid-binary /usr/bin/fernflower root 4755 fernflower.noarch: E: non-standard-executable-perm /usr/bin/fernflower 4755 fernflower.noarch: W: no-manual-page-for-binary fernflower fernflower.src: W: spelling-error Summary(en_US) decompiler -> recompiled, compiler, recompile fernflower.src: W: summary-not-capitalized C fernflower java decompiler fernflower.src: W: name-repeated-in-summary C fernflower fernflower.src: W: spelling-error %description -l en_US analytical -> analytically, analytic, catalytic fernflower.src: W: spelling-error %description -l en_US decompiler -> recompiled, compiler, recompile fernflower.src: E: description-line-too-long C Fernflower is the first actually working analytical decompiler for Java and probably fernflower.src: E: description-line-too-long C for a high-level programming language in general. Naturally it is still under development, fernflower.src: E: no-changelogname-tag fernflower.src:33: W: setup-not-quiet fernflower.src:8: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 4) fernflower.src: W: invalid-url Source0: fernflower-183.5153.8.tar.gz 2 packages and 0 specfiles checked; 8 errors, 14 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory fernflower.noarch: W: spelling-error Summary(en_US) decompiler -> recompiled, compiler, recompile fernflower.noarch: W: summary-not-capitalized C fernflower java decompiler fernflower.noarch: W: name-repeated-in-summary C fernflower fernflower.noarch: W: spelling-error %description -l en_US analytical -> analytically, analytic, catalytic fernflower.noarch: W: spelling-error %description -l en_US decompiler -> recompiled, compiler, recompile fernflower.noarch: E: description-line-too-long C Fernflower is the first actually working analytical decompiler for Java and probably fernflower.noarch: E: description-line-too-long C for a high-level programming language in general. Naturally it is still under development, fernflower.noarch: E: no-changelogname-tag fernflower.noarch: W: invalid-url URL: https://github.com/JetBrains/intellij-community/tree/master/plugins/java-decompiler/engine <urlopen error [Errno -2] Name or service not known> fernflower.noarch: E: setuid-binary /usr/bin/fernflower root 4755 fernflower.noarch: E: non-standard-executable-perm /usr/bin/fernflower 4755 fernflower.noarch: W: no-manual-page-for-binary fernflower 1 packages and 0 specfiles checked; 5 errors, 7 warnings. Requires -------- fernflower (rpmlib, GLIBC filtered): java-headless javapackages-tools Provides -------- fernflower: fernflower Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1662974 Buildroot used: fedora-29-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
