https://bugzilla.redhat.com/show_bug.cgi?id=1663642 Carl George <carl@george.computer> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carl@george.computer Assignee|nobody@xxxxxxxxxxxxxxxxx |carl@george.computer Flags| |fedora-review? --- Comment #1 from Carl George <carl@george.computer> --- Hello Dominik, I'm taking this review. I tried to run fedora-review for your spec file and it failed because of the test suite. It appears that the issue is already reported upstream [0]. We can proceed with the review by disabling the test suite for now (s/bcond_without check/bcond_with check/) if you like, or we can wait for upstream to fix the test suite. In the meantime, there are several other things that should be fixed in the spec file. * The summary and description lines should be no longer than 80 characters [1]. * Replace fancy single and double quotes (’ and ”) in description with standard ascii quotes (' and "). * Use the %pypi_source macro to define Source0 [2]. * Upstream uses setuptools in setup.py [3], so it needs to be listed as a build requirement. Furthermore, upstream specifically calls out setuptools >= 30.3.0 [4], so that minimum version requirement should be used with the build requirement. * The %python_provides macro should have an argument of python3-asynctest, not python3-mmtf. * Capitalize your changelog entry. * Instead of using the working directory for the tests, use the buildroot's sitelib by setting PYTHONPATH to %{buildroot}%{python3_sitelib}. [0]: https://github.com/Martiusweb/asynctest/issues/112 [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description [2]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi [3]: https://github.com/Martiusweb/asynctest/blob/v0.12.2/setup.py#L35 [4]: https://github.com/Martiusweb/asynctest/blob/v0.12.2/setup.py#L5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
