[Bug 1662534] Review Request: liquidctl - A tool for controlling NZXT liquid coolers, fans, and LED strips

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1662534

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Package looks good now, with the exception of the wrong filename for the .spec
file:

> Note: liquidctl-1.1.0-2.spec should be liquidctl.spec

Please fix that before importing the package. It would result in broken koji
builds, AFAIK.


Also, "BuildArch: noarch" propagates from the main package to sub-packages, so
specifying it twice isn't necessary - but it doesn't hurt, either, I guess.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux