https://bugzilla.redhat.com/show_bug.cgi?id=1663492 --- Comment #3 from Nikola Forró <nforro@xxxxxxxxxx> --- (In reply to Andrew Bauer from comment #1) > The %setup macro has been superseded by %autosetup. > Replace with "%autosetup -n %{project_name}-%{version}". I don't think %setup was superseded, but there is no reason not to use %autosetup here, so I'll replace it. > Did you have a specific reason to exclude the libpbf.so from provides? > I see that same exclusion in the core qt5-qtbase specfile. However, I'm not > sure this should be done for the qt5 plugins. For example, when I look at > the specfile for qt5-qtsvg plugin, it does not exclude the libqsvg.so > library the plugin package provides. I believe plugins are supposed to be excluded from provides, and only libraries (with a SONAME) are supposed to be there. > The qt5-qtsvg plugin package ties itself to the version of qt5-qtbase it was > built against with: > %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}} > > We should do the same for this package. Good point, I'll fix that. > If you plan to build against anything older than Fedora 28, then you need to > add %ldconfig_scriptlets to %install. No, I don't. Thanks, I'll make the changes ASAP. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
