https://bugzilla.redhat.com/show_bug.cgi?id=1663492 --- Comment #1 from Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> --- RPMLint looks good: >$ rpmlint /var/lib/mock/fedora-29-x86_64/result/*.rpm >4 packages and 0 specfiles checked; 0 errors, 0 warnings. The %setup macro has been superseded by %autosetup. Replace with "%autosetup -n %{project_name}-%{version}". replace "make %{?_smp_mflags}" with %make_build macro. Typically the %make_install macro is used in %install, instead of "make install". Looking at other qt5 packages, however, the norm seems to be "make install INSTALL_ROOT=%{buildroot}" so let's leave that as an exception. In my opinion, the package description could be better. If there was no better source of documentation then I'd certainly understand why the description is the same as the summary, but in this case the github project page has a nice detailed description. Recommend you use that: https://github.com/tumic0/QtPBFImagePlugin/#description Did you have a specific reason to exclude the libpbf.so from provides? I see that same exclusion in the core qt5-qtbase specfile. However, I'm not sure this should be done for the qt5 plugins. For example, when I look at the specfile for qt5-qtsvg plugin, it does not exclude the libqsvg.so library the plugin package provides. The qt5-qtsvg plugin package ties itself to the version of qt5-qtbase it was built against with: %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}} We should do the same for this package. If you plan to build against anything older than Fedora 28, then you need to add %ldconfig_scriptlets to %install. See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets Let me know if you have any questions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
