[Bug 1663090] Review Request: direvent - GNU directory event monitoring daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1663090



--- Comment #4 from Artur Iwicki <fedora@xxxxxxxxxx> ---
>%doc %{_datadir}/info/dir
>[...]
>%doc %{_datadir}/locale/da/LC_MESSAGES/direvent.mo
>[...]
>%doc %{_datadir}/man/man5/direvent.conf.5*
These files should not be marked as %doc. That is for documentation only. Well,
technically man pages and info files are documentation... but still, %doc is
used only extra documents. Think stuff like README.md or
SomeDetailedDescription.txt.

>%doc %{_datadir}/locale/da/LC_MESSAGES/direvent.mo
>[...]
>%doc %{_datadir}/locale/vi/LC_MESSAGES/direvent.mo
You can use a directory wildcard here (**) to avoid having to list every single
path, like this:
%{_datadir}/locale/**/LC_MESSAGES/direvent.mo

Also, you should include the licence file, like this:
%license COPYING
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

Regarding koji builds: do you intend this to be an EPEL-only package, not
available in Fedora?
If this is to go into Fedora, you should make (and post a link to) a koji
scratch build for Rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux