https://bugzilla.redhat.com/show_bug.cgi?id=1662565 --- Comment #2 from Randy Barlow <rbarlow@xxxxxxxxxx> --- Good catch on the bundled lib, I hadn't noticed that. I found an issue about it: https://github.com/signalapp/libsignal-protocol-c/issues/103 Looking at their CMake code, it does not seem they provide a way to use the system library. Unfortunately, they also don't seem to document the version of protobuf-c, so I asked in that ticket which version is bundled so I can mark it in the spec file. Looking at the commit history makes it seem like a fork of 1.1.1: https://github.com/signalapp/libsignal-protocol-c/commits/master/src/protobuf-c The BR on gcc-c++ was done because the cmake tool does look for the C++ compiler even though it doesn't seem to use it. We could probably make a patch for upstream to stop this, but for now I just installed it since it was harmless and easy. Here's a patch to address some of the problems: --- libsignal-protocol-c.spec.old 2019-01-05 09:30:40.885309220 -0500 +++ libsignal-protocol-c.spec 2019-01-05 09:29:52.800721370 -0500 @@ -2,7 +2,7 @@ Version: 2.3.2 Release: 1%{?dist} -License: GPLv3+ +License: GPLv3 Summary: Signal Protocol C library URL: https://github.com/signalapp/libsignal-protocol-c Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz @@ -12,6 +12,9 @@ BuildRequires: gcc-c++ BuildRequires: openssl-devel +# https://github.com/signalapp/libsignal-protocol-c/issues/103 +Provides: bundled(protobuf-c) = 1.1.1 + %description This is a ratcheting forward secrecy protocol that works in synchronous and asynchronous messaging @@ -21,8 +24,7 @@ %package devel Summary: Development files for libsignal-protocol-c -Requires: libsignal-protocol-c == %{version} -Requires: pkgconf-pkg-config +Requires: %{name}%{?_isa} = %{version}-%{release} %description devel @@ -59,5 +61,5 @@ %changelog -* Sat Dec 29 2018 Randy Barlow <bowlofeggs@xxxxxxxxxxxxxxxxx> - 2.3.0-1 +* Sat Jan 05 2019 Randy Barlow <bowlofeggs@xxxxxxxxxxxxxxxxx> - 2.3.2-1 - Initial release. New spec and SRPM: Spec URL: https://bowlofeggs.fedorapeople.org/libsignal-protocol-c.spec SRPM URL: https://bowlofeggs.fedorapeople.org/libsignal-protocol-c-2.3.2-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
