https://bugzilla.redhat.com/show_bug.cgi?id=1663090 --- Comment #2 from yagejhu@xxxxxxxxx --- (In reply to Artur Iwicki from comment #1) > >https://gitlab.com/yagehu/gnu-direvent-rpm-spec/blob/master/direvent.spec > Please provide a link to the raw file next time, not an HTML preview. > > >%description > >GNU Direvent monitors... > You should manually insert linebreaks into the description text. There > should be no lines over 80 characters. > https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description > > >./configure --prefix=/usr > Use %{_prefix} here. > Also, why not just use %configure? Does that not work for some reason? > > >%files > >%doc /usr/share/... > Use %{_datadir} here. > https://fedoraproject.org/wiki/Packaging:RPMMacros > > >/usr/share/man/man5/direvent.conf.5.gz > Do not assume that man pages will be gzip-compressed. > https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages > > >%install > >rm -rf ${buildroot} > Don't do this. > https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections > > Have you tried running a scratch build in koji? 'cause I'm pretty sure you > need "BuildRequires: gcc" on this one. Got it. Thanks for the advises. Will read docs, fix, and try on koji. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
