https://bugzilla.redhat.com/show_bug.cgi?id=1660814 --- Comment #6 from Antonio Trande <anto.trande@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed == Issues== - As i said before, to own all files and directories inside a "directory" is sufficient using this form %{_libdir}/directory/ so for the 'vst' sub-package is %{_libdir}/vst/ - I have just seen that '%{_libdir}/lv2' is a directory owned by the 'lv2-*' packages. In this case, '%{_libdir}/lv2' can be co-owned in this way: %dir %{_libdir}/lv2 %{_libdir}/lv2/carla.lv2/ Following the name used for packaging the "lv2" files, i suggest you to create a "lv2-carla" sub-package. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "zlib/libpng license", "GPL (v2 or later)", "GNU Lesser General Public License", "Unknown or generated", "GNU Lesser General Public License (v2 or later)", "GNU Lesser General Public License (v2.1 or later)", "ISC License", "*No copyright* Public domain", "BSL (v1.0)", "Expat License", "*No copyright* GNU Lesser General Public License (v2.1 or later)", "*No copyright* GPL (v2 or later)", "GPL (v2)", "BSD 2-clause "Simplified" License", "*No copyright* BSD 3-clause "New" or "Revised" License", "*No copyright* GPL (v2)". 771 files have unknown license. Detailed output of licensecheck in /home/sagitter/FedoraReview/1660814-Carla/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/vst [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/vst [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/lv2(lv2) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in Carla- debuginfo , Carla-debugsource [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 6481920 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: Carla-2.0.0-0.3.20181212git51f2073.fc30.x86_64.rpm Carla-devel-2.0.0-0.3.20181212git51f2073.fc30.x86_64.rpm Carla-vst-2.0.0-0.3.20181212git51f2073.fc30.x86_64.rpm Carla-debuginfo-2.0.0-0.3.20181212git51f2073.fc30.x86_64.rpm Carla-debugsource-2.0.0-0.3.20181212git51f2073.fc30.x86_64.rpm Carla-2.0.0-0.3.20181212git51f2073.fc30.src.rpm Carla.x86_64: W: no-manual-page-for-binary carla Carla.x86_64: W: no-manual-page-for-binary carla-control Carla.x86_64: W: no-manual-page-for-binary carla-database Carla.x86_64: W: no-manual-page-for-binary carla-jack-multi Carla.x86_64: W: no-manual-page-for-binary carla-jack-single Carla.x86_64: W: no-manual-page-for-binary carla-patchbay Carla.x86_64: W: no-manual-page-for-binary carla-rack Carla.x86_64: W: no-manual-page-for-binary carla-settings Carla.x86_64: W: no-manual-page-for-binary carla-single Carla-devel.x86_64: W: no-documentation Carla-vst.x86_64: W: spelling-error %description -l en_US contanis -> contains, contestant, constants Carla-vst.x86_64: W: no-documentation Carla-vst.x86_64: W: dangling-relative-symlink /usr/lib64/vst/carla.vst/carla-bridge-lv2-gtk2 ../../carla/carla-bridge-lv2-gtk2 Carla-vst.x86_64: W: dangling-relative-symlink /usr/lib64/vst/carla.vst/carla-bridge-lv2-gtk3 ../../carla/carla-bridge-lv2-gtk3 Carla-vst.x86_64: W: dangling-relative-symlink /usr/lib64/vst/carla.vst/carla-bridge-lv2-qt5 ../../carla/carla-bridge-lv2-qt5 Carla-vst.x86_64: W: dangling-relative-symlink /usr/lib64/vst/carla.vst/carla-bridge-lv2-x11 ../../carla/carla-bridge-lv2-x11 Carla-vst.x86_64: W: dangling-relative-symlink /usr/lib64/vst/carla.vst/carla-bridge-lv2.so ../../carla/carla-bridge-lv2.so Carla-vst.x86_64: W: dangling-relative-symlink /usr/lib64/vst/carla.vst/carla-bridge-native ../../carla/carla-bridge-native Carla-vst.x86_64: W: dangling-relative-symlink /usr/lib64/vst/carla.vst/carla-discovery-native ../../carla/carla-discovery-native Carla-vst.x86_64: W: dangling-relative-symlink /usr/lib64/vst/carla.vst/jack ../../carla/jack Carla-vst.x86_64: W: dangling-relative-symlink /usr/lib64/vst/carla.vst/resources ../../../share/carla/resources Carla-vst.x86_64: W: dangling-relative-symlink /usr/lib64/vst/carla.vst/styles ../../carla/styles 6 packages and 0 specfiles checked; 0 errors, 22 warnings. Rpmlint (debuginfo) ------------------- Checking: Carla-vst-debuginfo-2.0.0-0.3.20181212git51f2073.fc30.x86_64.rpm Carla-debuginfo-2.0.0-0.3.20181212git51f2073.fc30.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- Carla-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config Carla(x86-64) Carla (rpmlib, GLIBC filtered): /usr/bin/python3 /usr/bin/sh hicolor-icon-theme ld-linux-x86-64.so.2()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libX11.so.6()(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfluidsynth.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdk-3.so.0()(64bit) libgdk-x11-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) liblo.so.7()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpulse-simple.so.0()(64bit) libpulse-simple.so.0(PULSE_0)(64bit) libpulse.so.0()(64bit) libpulse.so.0(PULSE_0)(64bit) librt.so.1()(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) python3-qt5 rtld(GNU_HASH) shared-mime-info Carla-debuginfo (rpmlib, GLIBC filtered): Carla-vst (rpmlib, GLIBC filtered): Carla(x86-64) ld-linux-x86-64.so.2()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfluidsynth.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) liblo.so.7()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) rtld(GNU_HASH) Carla-debugsource (rpmlib, GLIBC filtered): Provides -------- Carla-devel: Carla-devel Carla-devel(x86-64) pkgconfig(carla-native-plugin) pkgconfig(carla-standalone) pkgconfig(carla-utils) Carla: Carla Carla(x86-64) application() application(carla-control.desktop) application(carla.desktop) libcarla_interposer-jack-x11.so()(64bit) libcarla_interposer-safe.so()(64bit) libcarla_interposer-x11.so()(64bit) libcarla_native-plugin.so()(64bit) libcarla_standalone2.so()(64bit) libcarla_utils.so()(64bit) libjack.so.0()(64bit) mimehandler(application/x-carla-project) Carla-debuginfo: Carla-debuginfo Carla-debuginfo(x86-64) debuginfo(build-id) Carla-vst: Carla-vst Carla-vst(x86-64) Carla-debugsource: Carla-debugsource Carla-debugsource(x86-64) Unversioned so-files -------------------- Carla: /usr/lib64/carla/carla-bridge-lv2.so Carla: /usr/lib64/carla/libcarla_interposer-jack-x11.so Carla: /usr/lib64/carla/libcarla_interposer-safe.so Carla: /usr/lib64/carla/libcarla_interposer-x11.so Carla: /usr/lib64/carla/libcarla_native-plugin.so Carla: /usr/lib64/carla/libcarla_standalone2.so Carla: /usr/lib64/carla/libcarla_utils.so Carla: /usr/lib64/carla/styles/carlastyle.so Carla: /usr/lib64/lv2/carla.lv2/carla-bridge-lv2.so Carla: /usr/lib64/lv2/carla.lv2/carla.so Carla: /usr/lib64/lv2/carla.lv2/libcarla_interposer-jack-x11.so Carla: /usr/lib64/lv2/carla.lv2/libcarla_interposer-safe.so Carla: /usr/lib64/lv2/carla.lv2/libcarla_interposer-x11.so Carla: /usr/lib64/lv2/carla.lv2/libcarla_native-plugin.so Carla: /usr/lib64/lv2/carla.lv2/libcarla_utils.so Carla-vst: /usr/lib64/vst/carla.vst/CarlaPatchbay.so Carla-vst: /usr/lib64/vst/carla.vst/CarlaPatchbay16.so Carla-vst: /usr/lib64/vst/carla.vst/CarlaPatchbay32.so Carla-vst: /usr/lib64/vst/carla.vst/CarlaPatchbayFX.so Carla-vst: /usr/lib64/vst/carla.vst/CarlaRack.so Carla-vst: /usr/lib64/vst/carla.vst/CarlaRackFX.so Carla-vst: /usr/lib64/vst/carla.vst/carla-bridge-lv2.so Carla-vst: /usr/lib64/vst/carla.vst/libcarla_interposer-jack-x11.so Carla-vst: /usr/lib64/vst/carla.vst/libcarla_interposer-safe.so Carla-vst: /usr/lib64/vst/carla.vst/libcarla_interposer-x11.so Carla-vst: /usr/lib64/vst/carla.vst/libcarla_native-plugin.so Carla-vst: /usr/lib64/vst/carla.vst/libcarla_utils.so Source checksums ---------------- https://github.com/falkTX/Carla/archive/51f20736b4e0b5d6416f2b7d4051f155f5858fbf/Carla-51f2073.tar.gz : CHECKSUM(SHA256) this package : e5b4ebd2a964dda46f3400ad3468eb0b8154a5de59088c5009491f76f69bb319 CHECKSUM(SHA256) upstream package : e5b4ebd2a964dda46f3400ad3468eb0b8154a5de59088c5009491f76f69bb319 Generated by fedora-review 0.6.1 (0d22628) last change: 2018-09-16 Command line :./try-fedora-review -m fedora-rawhide-x86_64 -b 1660814 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, BATCH, DISTTAG, EPEL5, EPEL7, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
