[Bug 1659833] Review Request: python-notify2 - Python interface to DBus notifications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1659833



--- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> ---
(In reply to Fabio Valentini from comment #2)
> 1) You can use %{pypi_source} for the value of the Source0: tag.
> 

I'm not a fan of those types of URL pre-fillers, so I avoided it.

> 2) Please fix the description - right now, it's a truncated, ill-formatted,
> plain-text version of the rST README file.
> 

Working on it.

> 3) LICENSE and docs/license.rst contain the same text, you can drop the
> second one from the %files section.
> 
> 4) Have you opened a bug against python-dbus regarding the missing provides?
> 

I may file a pull request to fix it, since dbus-python is built properly in
Mageia.

> 5) There's a small test suite shipped with the package, did you try running
> it?
> 

I did not because I don't know what satisfies "from gi.repository import
GdkPixbuf" used in the tests. It didn't work when I tried it in mock...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux