[Bug 1660814] Review Request: Carla - Audio plugin host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1660814



--- Comment #1 from Antonio Trande <anto.trande@xxxxxxxxx> ---
- Group tag is no longer used.

-
BuildRequires:  qt-devel
BuildRequires:  qt5-qtbase-devel

Why a mixed use of Qt version?

- 

# error: value "AudioVideo;AudioEditing;Qt;" for key "Categories" in group
"Desktop Entry" contains an unregistered value "AudioEditing"
sed -i "s|AudioVideo;AudioEditing;Qt;|AudioVideo;Qt;|" data/carla*.desktop
# values extending the format should start with "X-"
sed -i "s|Categories|X-Categories|" data/carla*.desktop

Use 'desktop-file-install' command for these changes.

- 

# fix libdir path
sed -i "s|/lib/carla|/lib64/carla|"
data/{carla,carla-control,carla-database,carla-jack-multi,carla-jack-single,carla-patchbay,carla-rack,carla-settings}

And on 32 bit systems?

Better:
sed -i "s|/lib/carla|/%{_lib}/carla|"
data/{carla,carla-control,carla-database,carla-jack-multi,carla-jack-single,carla-patchbay,carla-rack,carla-settings}

-

#!/usr/bin/python3 --> %{__python3}

- Do

%{_libdir}/%{pname}/
%{_libdir}/lv2/
%{_libdir}/vst/

contain versioned/unversioned soname?

- 

%dir %{_datadir}/%{pname}/
%{_datadir}/%{pname}/*

become

%{_datadir}/%{pname}/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux