https://bugzilla.redhat.com/show_bug.cgi?id=1660518 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-256: 8422d60238efdc0cc46141a7749563ee87263e8497aee51288e5da948ab8b437) is original. Ok. Summary verified from lib/Config/Model/Backend/Yaml.pm. Ok. TODO: Replace `config' with `configuration' in the summary. Description is verified from lib/Config/Model/Backend/Yaml.pm. Ok. License verified from lib/Config/Model/Backend/Yaml.pm, LICENSE. FIX: The license is `LGPLv2'. Not 'LGPLv2+' as stated in lib/Config/Model/Backend/Yaml.pm: This is free software, licensed under: The GNU Lesser General Public License, Version 2.1, February 1999 Change the license tag. No XS code, noarch BuildArch is Ok. There is no reason to require Perl 5.12.0. Ok. FIX: Remove a build-dependency on `perl(parent)'. It's used nowhere. All tests pass. Ok. $ rpmlint perl-Config-Model-Backend-Yaml.spec ../SRPMS/perl-Config-Model-Backend-Yaml-2.132-1.fc30.src.rpm ../RPMS/noarch/perl-Config-Model-Backend-Yaml-2.132-1.fc30.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Config-Model-Backend-Yaml-2.132-1.fc30.noarch.rpm drwxr-xr-x 2 root root 0 Dec 19 11:19 /usr/share/doc/perl-Config-Model-Backend-Yaml -rw-r--r-- 1 root root 2723 Dec 16 20:54 /usr/share/doc/perl-Config-Model-Backend-Yaml/CONTRIBUTING.md -rw-r--r-- 1 root root 354 Dec 16 20:54 /usr/share/doc/perl-Config-Model-Backend-Yaml/Changes -rw-r--r-- 1 root root 1485 Dec 16 20:54 /usr/share/doc/perl-Config-Model-Backend-Yaml/README.md drwxr-xr-x 2 root root 0 Dec 19 11:19 /usr/share/licenses/perl-Config-Model-Backend-Yaml -rw-r--r-- 1 root root 24661 Dec 16 20:54 /usr/share/licenses/perl-Config-Model-Backend-Yaml/LICENSE -rw-r--r-- 1 root root 4157 Dec 19 11:19 /usr/share/man/man3/Config::Model::Backend::Yaml.3pm.gz drwxr-xr-x 2 root root 0 Dec 19 11:19 /usr/share/perl5/vendor_perl/Config drwxr-xr-x 2 root root 0 Dec 19 11:19 /usr/share/perl5/vendor_perl/Config/Model drwxr-xr-x 2 root root 0 Dec 19 11:19 /usr/share/perl5/vendor_perl/Config/Model/Backend -rw-r--r-- 1 root root 8415 Dec 19 11:19 /usr/share/perl5/vendor_perl/Config/Model/Backend/Yaml.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Config-Model-Backend-Yaml-2.132-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(:VERSION) >= 5.10.1 1 perl(base) 1 perl(boolean) 1 perl(Carp) 1 perl(Config::Model) >= 2.131 1 perl(Config::Model::Backend::Any) 1 perl(Config::Model::Exception) 1 perl(File::Path) 1 perl(Log::Log4perl) 1 perl(strict) 1 perl(warnings) 1 perl(YAML::XS) >= 0.69 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. This package provides files owned by perl-Config-Model-2.130 package. But it requires `perl(Config::Model) >= 2.131' that does not contain them. No explicit Conflicts is necessary. Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Config-Model-Backend-Yaml-2.132-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(Config::Model::Backend::Yaml) = 2.132 1 perl-Config-Model-Backend-Yaml = 2.132-1.fc30 Binary provides are Ok. $ resolvedeps f30-build ../RPMS/noarch/perl-Config-Model-Backend-Yaml-2.132-1.fc30.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F30 (https://koji.fedoraproject.org/koji/taskinfo?taskID=31531132). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' items, consider fixing `TODO' items before building this package. Resolution: The package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
