https://bugzilla.redhat.com/show_bug.cgi?id=1659286 Alfredo Moralejo <amoralej@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amoralej@xxxxxxxxxx --- Comment #2 from Alfredo Moralejo <amoralej@xxxxxxxxxx> --- Some comments: - Do we need epoch = 1, it's a bit weird to bump it for a new package (I guess it's for compatibility with builds for non-fedora). - Line 74: "Provides: %{name}-doc" must be removed, subpackage name provides is automatic. - Hidden directory /usr/share/doc/python-openshift-doc/html/.doctrees should be removed after doc building. - There are errors related to shebang/permissions with file client.py: python3-openshift.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/openshift/dynamic/client.py /usr/bin/env python python3-openshift.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/openshift/dynamic/client.py 644 /usr/bin/env python If those are intended to be used as scripts, fix shebang (/usr/bin/env python should not be used, but versioned one) and make them executable. Otherwise, shebang should be removed and permissions should be kept to 644. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
