Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ladspa-blop-plugins - Bandlimited LADSPA Oscillator Plugins https://bugzilla.redhat.com/show_bug.cgi?id=292351 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-09-21 00:53 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 4baedbf1e7cacc7d1034c4bcd5556d6f blop-0.2.8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Pacakge ladspa-blop-plugins-0.2.8-5.fc8 -> Provides: adsr_1653.so adsr_1680.so amp_1654.so blop = 0.2.8-4.fc8 branch_1673.so dahdsr_2021.so difference_2030.so fmod_1656.so interpolator_1660.so lp4pole_1671.so parabola_1649_data.so product_1668.so pulse_1645.so quantiser100_2029.so quantiser20_2027.so quantiser50_2028.so random_1661.so ratio_2034.so sawtooth_1641.so sawtooth_1641_data.so sequencer16_1677.so sequencer32_1676.so sequencer64_1675.so square_1643.so square_1643_data.so sum_1665.so sync_pulse_2023.so sync_square_1678.so tracker_2025.so triangle_1649.so Requires: ladspa libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.3.4) libm.so.6 rtld(GNU_HASH) + Not a GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review