https://bugzilla.redhat.com/show_bug.cgi?id=1659759 Javier Peña <jpena@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@xxxxxxxx Flags| |needinfo?(projects.rg@smart | |.ms) --- Comment #2 from Javier Peña <jpena@xxxxxxxxxx> --- There are two small details to fix: - The package has no Requires at all. A quick look at https://github.com/os/slacker/blob/master/requirements.txt shows that we should include python-requests as a requirement. - fedora-review is complaining that /usr/lib/python3.7/site-packages/slacker/utils.py is a non-executable script. It includes a python2 shebang (#!/usr/bin/python) even in the python3 subpackage. Could you remove the shebang? Once those issues are fixed, it should be good to go (I'll take care of running fedora-review then). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
