https://bugzilla.redhat.com/show_bug.cgi?id=1659281 Javier Peña <jpena@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Javier Peña <jpena@xxxxxxxxxx> --- In general terms the spec looks ok to me, there are just a couple issues to fix: - There is no need to add an explicit Requires: for python2 or python3, the build process will figure it out and add it to the package. - fedora-review complains that the spec from the SRPM and the one in the bug are different, could you fix that? - The cleanup for .buildinfo after building docs is not cleaning .doctrees, and rpmlint complains about that - Finally, there is an inconsistency in the build requirements for the doc subpackage when using python2: %else BuildRequires: python2-sphinx BuildRequires: python3-recommonmark <-- should be python2 %endif -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
