https://bugzilla.redhat.com/show_bug.cgi?id=1658851 --- Comment #5 from Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> --- > TODO: Except I do not recommend running the optional tests with Test::Kwalitee or Test::Pod. They are very fragile and tends to break when somebody updates the modules (Test::Kwalitee is a list of subjective rules how a good Perl code looks like). Thank you. I never would have suspected this. Done. > TODO: You should also build-require `perl(POSIX)' if you decided to hard-require it. It's good to assure the tests have a similar environment as the package has after installing on a user's system. Otherwise it can happen that the tests test a different code path than the user will perform (see all the $HAS_POSIX conditions in the code). Done. > TODO: You can filter out the non-versioned `perl(Time::ParseDate)' dependency as it's redundant and pollutes the metadata. I was not sure how to resolve this, since the non-versioned dependency was being automatically picked up by rpm. Google to the rescue. That's when I discovered the __requires_exclude macro and added this to the top of the specfile: %global __requires_exclude perl\\(Time::ParseDate\\) That did it. Thank you for your time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
