https://bugzilla.redhat.com/show_bug.cgi?id=1658153 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #11 from Artur Iwicki <fedora@xxxxxxxxxx> --- >BuildRoot: /var/tmp/%{name}buildroot >... >%clean >rm -rf $RPM_BUILD_ROOT The BuildRoot: tag and the %clean section should not be used. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections >Source: ftp://ftp.ourproject.org/pub/wdune/wdune-0.99.tar.bz2 You can use %{version} as part of the Source URL so you don't have to update this every time. >mkdir -p $RPM_BUILD_ROOT/%{_datadir}/icons/Bluecurve/48x48/apps This directory doesn't seem to be used anywhere after it's created. >%files >... >/usr/bin/dune >... >/usr/share/pixmaps/dune.png Use %{_bindir}, %{_datadir} and other relevant macros here, instead of absolute paths. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
