https://bugzilla.redhat.com/show_bug.cgi?id=1657410 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Elliott Sales de Andrade from comment #1) > > # Downloads data. All tests pass locally in mock > > # mock -r fedora-rawhide-x86_64 rebuild <srpm> --enable-network --rpmbuild-opts="--with tests" > > %bcond_with tests > > Surely not all of them? You could select out the ones that actually use the > network? Updated. I'd initially thought it did lots of dataset tests, but they're all in one file so I've disabled that one. > > > This work is made available by a community of people, amongst which the INRIA > > Parietal Project Team and D esposito lab at Berkeley. > > There's an apostrophe missing in the name here. Nice catch! Re-added. It messes up the syntax highlighting in vim, so I'd removed it temporarily! > > > Version: 0.0.1b > > Release: 1%{?dist} > > Prerelease information (b) belongs in the Release tag, which should start > with 0: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ > #_prerelease_versions Updated. > > > # Not in setup.py so generator probably wont pick them up > > Try sending a patch upstream? Actually, are you sure you need these? I see > duplicate python3.7dist() and python3dist() requirements on the result. Yeh. The autogenerator is a lot smarter than I thought! It wasn't picking up six, so I've only added that manually now. > Both numpydoc and sphinx_gallery are bundled. They're only used for building > docs, but maybe petition upstream to stop doing that? Removed in %prep, and will open an issue upstream now. Updated spec/srpm: https://ankursinha.fedorapeople.org/python-nistats/python-nistats-0.0.1-0.1b0.fc29.src.rpm https://ankursinha.fedorapeople.org/python-nistats/python-nistats.spec Cheers! Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
