https://bugzilla.redhat.com/show_bug.cgi?id=1657533 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #1) Thanks for the review Robert. > - Add the date of your snapshot in Release: > > Release: 1.20181209git374cdbc%{?dist} Updated. > > - Add a BR for gcc Updated. > > - Add these licenses and add the license breakdown in comment > > BSD (unspecified) > ----------------- > genesis-2.4-374cdbc7971ccffa0a0fe270ce9904e30c0802dc/genesis/src/diskio/ > interface/netcdf/netcdf-3.4/copyright.html > genesis-2.4-374cdbc7971ccffa0a0fe270ce9904e30c0802dc/genesis/src/diskio/ > interface/netcdf/netcdf-3.4/src/libsrc/netcdf.h This is bundled netcdf that we do not use. We delete it in %prep. > MIT (old) > --------- > genesis-2.4-374cdbc7971ccffa0a0fe270ce9904e30c0802dc/genesis/src/newconn/ > fac_debug.h .. Added. > > NTP License > ----------- > genesis-2.4-374cdbc7971ccffa0a0fe270ce9904e30c0802dc/genesis/src/contrib/ > xplot/main.c > genesis-2.4-374cdbc7971ccffa0a0fe270ce9904e30c0802dc/genesis/src/contrib/ > xplot/psdriver.c This is another piece of bundled software that we delete in %prep > genesis-2.4-374cdbc7971ccffa0a0fe270ce9904e30c0802dc/pgenesis/src/par/tvdefs.h This is in "pgenesis", not genesis. (It's in the git tar, but we only build genesis) > > Public domain > ------------- > genesis-2.4-374cdbc7971ccffa0a0fe270ce9904e30c0802dc/genesis/Scripts/VAnet2/ > README.html Added. Updated spec/srpm: https://ankursinha.fedorapeople.org/genesis-simulator/genesis-simulator.spec https://ankursinha.fedorapeople.org/genesis-simulator/genesis-simulator-2.4-1.20181209git374cdbc.fc29.src.rpm Cheers! Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
