https://bugzilla.redhat.com/show_bug.cgi?id=1658199 Bug ID: 1658199 Summary: Review Request: netatalk - Open Source Apple Filing Protocol(AFP) File Server Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: zonexpertconsulting@xxxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/netatalk.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1351/31321351/netatalk-3.1.11-2.fc30.src.rpm Description: Netatalk is a freely-available Open Source AFP file server. A *NIX/*BSD system running Netatalk is capable of serving many Macintosh clients simultaneously as an AppleShare file server (AFP). Fedora Account System Username: Kni RPMLint Output -------------- netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/afpd netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/cnid_dbd > Appears to be a false positive. setgid and setuid seem to be in the correct order. > Please inspect and confirm: >[1] https://github.com/Netatalk/Netatalk/blob/branch-netatalk-3-1/etc/afpd/afprun.c#L121 >[2] https://github.com/Netatalk/Netatalk/blob/branch-netatalk-3-1/etc/cnid_dbd/cnid_metad.c#L512 netatalk.x86_64: E: setuid-binary /usr/bin/afppasswd root 4755 netatalk.x86_64: E: non-standard-executable-perm /usr/bin/afppasswd 4755 > afppasswd functions similar to passwd, which also generates the same message from rpmlint netatalk.x86_64: W: no-manual-page-for-binary cnid2_create > confirmed. No man page exists for this binary NOTES ----- This specfile is based on the spcfile provided by upstream developer, HAT, shown in this older review request: https://bugzilla.redhat.com/show_bug.cgi?id=1520024 This spec files uses Epoch for historical reasons, and this seems to be one of those things where, if you start down this path, you never go back. I am not confident that removing this would not cause any unforseen problems, so I left it in. I found the way the specfile computes the pkgver and xslver globals to be unusual. See the first few lines of the specfile. I could try to move these into %build if someone thinks that should be done. Lastly, this review request is intended for el7 and fedora only. I will handle any requests for el6 support, if there are any, later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
