https://bugzilla.redhat.com/show_bug.cgi?id=1656533 --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok FIX: License should be '(GPL+ or Artistic) and Public Domain', because files COPYRIGHT and CREDITS have license Public Domain, See Types-DateTime-0.002/COPYRIGHT line 13-17. Description is ok Source0 is ok FIX: Please update URL to use link to metacpan.org https://metacpan.org/release/Types-DateTime/ All tests passed BuildRequires FIX: Please add following missing build-requires: - coreutils - spec file: line 34 - findutils - spec file: line 34 - make - spec file: line 32 - perl-generators - perl-interpreter - spec file: line 28 - perl(Moose) >= 2.06 - t/02mxtdt.t:31 - perl(Moose::Util::TypeConstraints) - t/02mxtdt.t:26 - perl(strict) - Makefile.PL:1, lib/Types/DateTime.pm:2 - perl(Type::Library) - lib/Types/DateTime.pm:17 - perl(Type::Utils) - lib/Types/DateTime.pm:22 - perl(Type::Standard) - lib/Types/DateTime.pm:21 - perl(warnings) - lib/Types/DateTime.pm:3 - optional - perl(Locale::Maketext) - t/02mxtdt.t:128 $ rpm -qp --requires perl-Types-DateTime-0.002-1.fc30.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.28.1) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 perl run-time dependencies are missing. $ rpm -qp --provides perl-Types-DateTime-0.002-1.fc30.noarch.rpm | sort | uniq -c 1 perl-Types-DateTime = 0.002-1.fc30 Binary provides are not complete FIX: Provides and run-time requires were not added due to missing build-requires perl-generators. $ rpmlint ./perl-Types-DateTime* perl-Types-DateTime.noarch: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s perl-Types-DateTime.src: W: spelling-error Summary(en_US) coercions -> coercion, coercion's, coercion s 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok If you want to add the package to EPEL, please ignore these two TODO TODO: The easier way to remove .packlist is used NO_PACKLIST option, which is part of perl(ExtUtils::MakeMaker) >= 6.76. It can be used in all Fedoras. The command is %{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 TODO: Remove the deleting empty directories in %install section. This is default behavior for Fedoras. Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Not approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
