https://bugzilla.redhat.com/show_bug.cgi?id=1654876 --- Comment #7 from Dillen Meijboom <info@xxxxxxxxxxxx> --- (In reply to Robert-André Mauchin from comment #6) > > I will fix this but can you explain when it is appropriate to create a separate package for documentation? Or is this never suppose to happen? > > Usually when the documentation is over 1MB or contains a lot of files. > > > Also why are "install -d %{buildroot}/%{_datadir}/doc/%{name}" and "%{_pkgdocdir} in %files" not needed? > > You don't need to create the dir, specifying %doc README.md will take care > of that. Thanks for the information. I tried building the package but I can't get the tests to work. I'm not sure what to do next, should I simply comment-out the %check function or create an issue upstream and make sure the tests work? Current spec file: https://copr-be.cloud.fedoraproject.org/results/dmeijboom/Zsh/fedora-rawhide-x86_64/00832436-zsh-autosuggestions/zsh-autosuggestions.spec Build logs: https://pastebin.com/aMAV46iB -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
