Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ilmbase - Abraction/convenience libraries https://bugzilla.redhat.com/show_bug.cgi?id=251521 ------- Additional Comments From kwizart@xxxxxxxxx 2007-09-20 10:01 EST ------- OK - rpmlint on rpm packages is quiet Should fix - rpmlint on installed files show: (on fc6 x86_64 at least ) W: ilmbase incoherent-version-in-changelog 1.0.0-1 1.0.0-1.kwizart.fc6 W: ilmbase unused-direct-shlib-dependency /usr/lib64/libHalf.so.6.0.0 /lib64/libpthread.so.0 W: ilmbase unused-direct-shlib-dependency /usr/lib64/libHalf.so.6.0.0 /lib64/libm.so.6 W: ilmbase unused-direct-shlib-dependency /usr/lib64/libHalf.so.6.0.0 /lib64/libgcc_s.so.1 W: ilmbase unused-direct-shlib-dependency /usr/lib64/libIex.so.6.0.0 /lib64/libm.so.6 W: ilmbase unused-direct-shlib-dependency /usr/lib64/libImath.so.6.0.0 /lib64/libpthread.so.0 W: ilmbase unused-direct-shlib-dependency /usr/lib64/libIlmThread.so.6.0.0 /lib64/libm.so.6 You may advice upstream or maybe uses this between configure and make (or the right ld options...). (Note that this is usually a "should fix" field). # clean unused-direct-shlib-dependencies sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool Should fix - You may add make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p -c" to prevent timestamp changes when installing headers (minor issue, but easy to fix) Must - Well I expect you will change Summary to reflect the one from the review (which is better indeed). Must - ImathGLU.h:#include <GL/glu.h>, half.h:#include <iostream> / I wonder if yu have to add Requires: mesa-libGLU-devel (and boost-devel as i expect?) for ilmbase-devel, might be needed as BR also... (i don't remember if mesa is in the minimal Buildsys, seems not...) Note that since ilmbase owns /usr/include/OpenEXR, ownership have to be removed from the new OpenEXR-devel package... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review