https://bugzilla.redhat.com/show_bug.cgi?id=1655909 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- The Url and Source0 addresses are Ok. A Source0 archive (SHA-256: afe51d576bb57eef247accaa656f8f34418a5289657ca40c4613087b344e2091) is original. Ok. A summary verified from lib/Syntax/Keyword/Try.pm. Ok. A description verified from lib/Syntax/Keyword/Try.pm. Ok. A license verified from lib/Syntax/Keyword/Try.xs, lib/Syntax/Keyword/Try.pm, LICENSE. Ok. BuildRequires are Ok. All tests pass. Ok. $ rpmlint perl-Syntax-Keyword-Try.spec ../SRPMS/perl-Syntax-Keyword-Try-0.09-1.fc30.src.rpm ../RPMS/x86_64/perl-Syntax-Keyword-Try-* perl-Syntax-Keyword-Try.src: W: summary-not-capitalized C try/catch/finally syntax for perl perl-Syntax-Keyword-Try.x86_64: W: summary-not-capitalized C try/catch/finally syntax for perl 4 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Syntax-Keyword-Try-0.09-1.fc30.x86_64.rpm drwxr-xr-x 2 root root 0 Dec 4 10:26 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Dec 4 10:26 /usr/lib/.build-id/8d lrwxrwxrwx 1 root root 70 Dec 4 10:26 /usr/lib/.build-id/8d/5e05056f2d459801d09983ab95a83d8e84a047 -> ../../../../usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Try/Try.so drwxr-xr-x 2 root root 0 Dec 4 10:26 /usr/lib64/perl5/vendor_perl/Syntax drwxr-xr-x 2 root root 0 Dec 4 10:26 /usr/lib64/perl5/vendor_perl/Syntax/Keyword -rw-r--r-- 1 root root 10697 Dec 4 10:26 /usr/lib64/perl5/vendor_perl/Syntax/Keyword/Try.pm drwxr-xr-x 2 root root 0 Dec 4 10:26 /usr/lib64/perl5/vendor_perl/auto/Syntax drwxr-xr-x 2 root root 0 Dec 4 10:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword drwxr-xr-x 2 root root 0 Dec 4 10:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Try -rwxr-xr-x 1 root root 23232 Dec 4 10:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Keyword/Try/Try.so drwxr-xr-x 2 root root 0 Dec 4 10:26 /usr/share/doc/perl-Syntax-Keyword-Try -rw-r--r-- 1 root root 2054 Nov 8 2017 /usr/share/doc/perl-Syntax-Keyword-Try/Changes -rw-r--r-- 1 root root 10128 Nov 8 2017 /usr/share/doc/perl-Syntax-Keyword-Try/README drwxr-xr-x 2 root root 0 Dec 4 10:26 /usr/share/licenses/perl-Syntax-Keyword-Try -rw-r--r-- 1 root root 18418 Nov 8 2017 /usr/share/licenses/perl-Syntax-Keyword-Try/LICENSE -rw-r--r-- 1 root root 5852 Dec 4 10:26 /usr/share/man/man3/Syntax::Keyword::Try.3pm.gz File permissions and locations are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Syntax-Keyword-Try-0.09-1.fc30.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libpthread.so.0()(64bit) 1 libpthread.so.0(GLIBC_2.2.5)(64bit) 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(Carp) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Syntax-Keyword-Try-0.09-1.fc30.x86_64.rpm | sort -f | uniq -c 1 perl(Syntax::Keyword::Try) = 0.09 1 perl-Syntax-Keyword-Try = 0.09-1.fc30 1 perl-Syntax-Keyword-Try(x86-64) = 0.09-1.fc30 Binary provides are Ok. Package builds in F30 (https://koji.fedoraproject.org/koji/taskinfo?taskID=31262160). Ok. The package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
