[Bug 1634014] Review Request: python-grpcio - A high performance, open-source universal RPC framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1634014



--- Comment #5 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> ---
> Source0:       %pypi_source

Source0:       %{pypi_source}

> BuildRequires: python3-devel >= 3.4
> BuildRequires: python3-Cython
> BuildRequires: python3-setuptools
> BuildRequires: python3-six >= 1.5.2

Would be good to move this under python3- subpackage.

> export GRPC_PYTHON_CFLAGS="%{build_cflags}"

I see that you BR gcc-c++, you also need to export CXXFLAGS.

---

Other than this, looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux