Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: cgi-util - A C library for creating Common Gateway Interface ("CGI") programs
https://bugzilla.redhat.com/show_bug.cgi?id=253941
------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-09-20 08:23 EST -------
For 2.2.1-10:
* autotools patch
- Please don't use a meaninglessly large patch like
Patch0.
This type of patch makes it very difficult to for us to
check what points are to be fixed by this patch.
* Apply patch for the points that are really needed fixing
and really call autotools if needed.
* And please check it carefully if autotools really has
to be called.
* disttag
- Please consider to use disttag.
http://fedoraproject.org/wiki/Packaging/DistTag
* License
- License should be "LGPLv2+" as no source specifies the version.
* Macro style
- Please choose whether you use %name or %{name}
* rpmlint
-------------------------------------------------------
cgi-util.i386: W: spurious-executable-perm /usr/share/doc/cgi-util-2.2.1/test.cgi
cgi-util.i386: W: spurious-executable-perm
/usr/share/doc/cgi-util-2.2.1/filetest.cgi
-------------------------------------------------------
- First of all, these two files are actually wrong because
these files uses non-existing builddir.
i.e. These two files can work at build time and no longer
works when installed as this
- And the permission should be 0644 as this is marked as documents.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review