https://bugzilla.redhat.com/show_bug.cgi?id=1655421 Vasiliy Glazov <vascom2@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vascom2@xxxxxxxxx --- Comment #1 from Vasiliy Glazov <vascom2@xxxxxxxxx> --- 1. Remove Group: Development/Other 2. Source0: must be URL to download sources. 3. Are you sure this need? %define debug_package %{nil} Also use %global instead of %define. 4. Instead %setup -q -n hw-probe-%{version} use new macro %autosetup -n hw-probe-%{version} 5. Bugreport this to upstream chmod 0644 README.md 6. Instead make install prefix=%{_prefix} DESTDIR=%{buildroot} use new macro %make_install prefix=%{_prefix} 7. Remove clean section. 8. Remove %defattr(-,root,root,-) from %file section. 9. Add changelog section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
