https://bugzilla.redhat.com/show_bug.cgi?id=1650987 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #18 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Alain V. from comment #16) > Thank you so much Fabio for the review/advises. > > I understand Fedora policy, to not include .a archive libs. I list only 7 > such files on my system... > $ ls -1 /usr/lib64/*.a|wc -l > 7 Yeah, and those 7 probably shouldn't be there either. > To simplify the situation, I propose to drop the static sub-package and > such, I patched even more the Makefile : > > Spec URL: > https://copr-be.cloud.fedoraproject.org/results/avigne/libgenht/fedora- > rawhide-x86_64/00832049-libgenht/libgenht.spec > SRPM URL: > https://copr-be.cloud.fedoraproject.org/results/avigne/libgenht/fedora- > rawhide-x86_64/00832049-libgenht/libgenht-1.0.1-3.fc30.src.rpm > > The mageia-cauldron is failing again, and looking at root.log.gz, I don't > see the reason why. > Somebody should report something somewhere ? It's a known issue in mock / COPR, I think - failed downloads due to network issues aren't retried. > Concerning -Wl,-soname,$(LIBSO) , upstream Makefile will NOT include this > statement, as it is a gcc flag only, and upstream is "compiler agnostic". I don't think that's true, since the "-Wl," flag only passes through the following arguments to the linker. But alright, if upstream doesn't want to add it, keep the flag in your patch for the Makefile. > I hope what I propose makes sense ? > Alain Yes, it does, the package looks good now! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
