https://bugzilla.redhat.com/show_bug.cgi?id=1653481 Robert-André Mauchin <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> --- What's your FAS account? https://admin.fedoraproject.org/accounts Where is the link to the SPEC file? The SPEC in the SRPM is not in line with Fedora Packaging Guidelines: read about them https://docs.fedoraproject.org/en-US/packaging-guidelines/ - Group is not used in Fedora - Split BR and RR one per line - Correct license shorthand is GPLv3+ - Version: 0.99pl1188 → Use extraver for pl1188 See https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_unsortable_versions - Your list of Requires is weird: does your app really need firefox, pinta, kolourpaint, audacity, lxterminal, ImageMagick, aqsis-core to function? Consider moving them to Recommends instead. - Release should contain %{?dist} Release: 1%{?dist} - You could use %autosetup - Use the %configure macro - Use the %make_build macro - Do not use rm -rf $RPM_BUILD_ROOT at the start of install - Use %{_bindir}, %{_datadir}, %{_mandir} and so on - You should not create this dir yourself mkdir -p $RPM_BUILD_ROOT/usr/lib/debug/usr/bin/ - use "install -p" to keep timestamps - /usr/lib/rpm/find-debuginfo.sh should not be rin by you, it will be automatically by the build process. - Add you name to the %changelog entry, add the release tag to the changelog entry - Put the %changelog section at the end of the SPEC after %files - Validate the .desktop file: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage - Consider adding an Appdata file: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ - Consider doing a mockbuild after you updated your SPEC: spectool -g *.spec fedpkg --release f30 srpm fedpkg --release f30 mockbuild --mock-config fedora-rawhide-x86_64 --no-cleanup-after - Run rpmlint on your resulting RPMs - Consider doing a scratch build too to see if everything works fine fedpkg --release f30 scratch-build --srpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
