https://bugzilla.redhat.com/show_bug.cgi?id=1649552 --- Comment #6 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> --- >From the spec: # original source: http://hg.openjdk.java.net/jmc/jmc/archive/tip.tar.gz # Execute this script to download and generate source tarball: # ./generate_jmc_tarball.sh Source0: %{name}-%{version}.tar.gz So this seems a snapshot release. Please adapt in a similar fashion as jmc-core (but use 0.<date>hg<sha> instead). It's also nice to include the tarball generation script as Source in the spec file so that it'll be available in the SRPM. I'm getting a build failure: [INFO] {osgi.os=linux, osgi.ws=gtk, org.eclipse.update.install.features=true, osgi.arch=x86_64} [ERROR] Cannot resolve project dependencies: [ERROR] Software being installed: org.openjdk.jmc.feature.rcp.feature.group 7.0.0.qualifier [ERROR] Missing requirement: org.openjdk.jmc.feature.rcp.feature.group 7.0.0.qualifier requires 'javax.activation-api 0.0.0' but it could not be found [ERROR] [ERROR] See http://wiki.eclipse.org/Tycho/Dependency_Resolution_Troubleshooting for help. [ERROR] Cannot resolve dependencies of MavenProject: org.openjdk.jmc:org.openjdk.jmc.feature.rcp:7.0.0-SNAPSHOT @ /builddir/build/BUILD/jmc-7.0.0/application/org.openjdk.jmc.feature.rcp/pom.xml: See log for details -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException error: Bad exit status from /var/tmp/rpm-tmp.LYaiiI (%build) Bad exit status from /var/tmp/rpm-tmp.LYaiiI (%build) Looks like upstream wants 'osgi(javax.activation-api)', but jaf only provides these: $ rpm -q --provides jaf jaf = 1.2.1-2.fc28 mvn(com.sun.activation:all:pom:) = 1.2.1 mvn(com.sun.activation:jakarta.activation) = 1.2.1 mvn(com.sun.activation:jakarta.activation:pom:) = 1.2.1 mvn(jakarta.activation:jakarta.activation-api) = 1.2.1 mvn(jakarta.activation:jakarta.activation-api:pom:) = 1.2.1 osgi(com.sun.activation.jakarta.activation) = 1.2.1 osgi(jakarta.activation-api) = 1.2.1 So a patch changing 'javax.activation-api' to 'jakarta.activation-api' might solve the problem. There are many build warnings: 1) [WARNING] The POM for org.apache.maven.plugins:maven-install-plugin:jar:2.3.1 is missing, no dependency information available [WARNING] The POM for org.apache.maven.plugins:maven-site-plugin:jar:3.3 is missing, no dependency information available Perhaps '%pom_remove_plugin org.apache.maven.plugins:maven-site-plugin' etc. would help? 2) [WARNING] Multiple artifacts detected for osgi.bundle,B,1.0.0 [WARNING] /usr/share/java/eclipse-tests/eclipse/plugins/org.eclipse.pde.build.tests_1.1.800.v20180409-1128/resources/248767/build2/plugins/B and /usr/share/java/eclipse-tests/eclipse/plugins/org.eclipse.pde.build.tests_1.1.800.v20180409-1128/resources/208011/plugins/B have the same ID and version. [WARNING] /usr/share/java/eclipse-tests/eclipse/plugins/org.eclipse.pde.build.tests_1.1.800.v20180409-1128/resources/208011/plugins/B will be preferred. Seems this is an issue with the eclipse-tests package. It makes the build log rather cluttered. It would be nice to be able to a) silence them if they're ok b) fix eclipse-tests so no warnings are produced. Again from the spec: [...] %description Java Mission Control is a powerful profiler for HotSpot JVMs and has an advanced set of tools that enables efficient and detailed analysis of the extensive data collected by Java Flight Recorder. The tool chain enables developers and administrators to collect and analyze data from Java applications running locally or deployed in production environments. %global debug_package %{nil} %global _jmcdir %{_libdir}/%{name} [...] Is JMC a no-arch package or does it include arch specific binaries? If no-arch, then use 'BuildArch: noarch' and remove the '%global debug_package %{nil}' line. In general, please keep rpm globals in the preamble of the spec file not mixed in with the rest (description in this case). Any particular reason that _jmcdir is being defined to be /usr/lib64/jmc? Some changelog entries suggest /usr/share/jmc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
