Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: desktop-printing https://bugzilla.redhat.com/show_bug.cgi?id=225682 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2007-09-20 01:13 EST ------- rpmlint gave me desktop-printing.src:25: W: prereq-use gtk2 >= %{gtk_version} The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. desktop-printing.src: W: mixed-use-of-spaces-and-tabs (spaces: line 25, tab: line 1) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. desktop-printing.src: W: no-url-tag The URL tag is missing. desktop-printing.i386: W: non-conffile-in-etc /etc/dbus-1/system.d/printdriverselector.conf A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. desktop-printing.i386: W: non-conffile-in-etc /etc/xdg/autostart/redhat-print-applet.desktop A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. desktop-printing.i386: W: invalid-license GPL The value of the License tag was not recognized. Known values are: "Adobe", "Affero GPL", "AFL", "ARL", "ASL 1.0", "ASL 1.0+", "ASL 1.1", "ASL 1.1+", "ASL 2.0", "ASL 2.0+", "APSL 2.0", "APSL 2.0+", "Artistic 2.0", "Artistic clarified", "BitTorrent", "Boost", "BSD", "BSD with advertising", "CeCILL", "CDDL", "CPL", "Condor", "Copyright only", "Cryptix", "Crystal Stacker", "EPL", "eCos", "EFL 2.0", "EFL 2.0+", "EU Datagrid", "Giftware", "Glide", "gnuplot", "GPL+", "GPL+ or Artistic", "GPLv2", "GPLv2 with exceptions", "GPLv2+", "GPLv3", "GPLv3+", "IBM", "IJG", "ImageMagick", "iMatix", "Intel ACPI", "Interbase", "ISC", "Jabber", "JasPer", "LGPLv2", "LGPLv2 with exceptions", "LGPLv2+", "LGPLv3", "LGPLv3+", "libtiff", "LPL", "LPPL", "mecab-ipadic", "MIT", "MPLv1.0", "MPLv1.0+", "MPLv1.1", "MPLv1.1+", "NCSA", "NGPL", "NOSL", "Netscape", "Nokia", "OpenLDAP", "OpenPBS", "OSL 1.0", "OSL 1.0+", "OSL 1.1", "OSL 1.1+", "OSL 2.0", "OSL 2.0+", "OSL 3.0", "OSL 3.0+", "OpenSSL", "Phorum", "PHP", "Public Domain", "Python", "QPL", "RPSL", "Ruby", "Sleepycat", "SISSL", "SLIB", "SPL", "TCL", "UCD", "Vim", "VNLSL", "VSL", "W3C", "WTFPL", "wxWindows", "xinetd", "Zend", "ZPLv1.0", "ZPLv1.0+", "ZPLv2.0", "ZPLv2.0+", "ZPLv2.1", "ZPLv2.1+", "zlib", "CDL", "FBSDDL", "GFDL", "IEEE", "OFSFDL", "Open Publication", "CC-BY", "CC-BY-SA", "DSL", "Free Art", "Arphic", "Bitstream Vera", "mplus", "OFL", "Utopia", "XANO", "Redistributable, no modification permitted", "Freely redistributable without restriction". desktop-printing.i386: E: invalid-desktopfile /usr/share/applications/gnome-default-printer.desktop .desktop file is not valid, check with desktop-file-validate SHOULD: 1) Use "sed -i -e 's|\t| |g' desktop-printing.spec" 2) Change License tag 3) PreReq is now deprecated. 4) Preserve timestamp in cp or install command usage. 5) use make %{?_smp_mflags} 6) This package don't need to own /etc/gconf/schemas 7) use %config(noreplace) for %{_sysconfdir}/dbus-1/system.d/*.conf 8) desktop-file-validate on redhat-print-applet.desktop gave me /etc/xdg/autostart/redhat-print-applet.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated /etc/xdg/autostart/redhat-print-applet.desktop: error: value "TrayIcon" in key "Categories" in group "Desktop Entry" is a reserved category, so a "OnlyShowIn" key must be included ==> Add OnlyShowIn=GNOME; to /etc/xdg/autostart/redhat-print-applet.desktop also, Do we need to ignore rpmlint warning for desktop file installed at /etc/xdg/autostart/redhat-print-applet.desktop ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review